diff --git a/.github/workflows/run.yml b/.github/workflows/run.yml index ae1e8695b..c19983fe9 100644 --- a/.github/workflows/run.yml +++ b/.github/workflows/run.yml @@ -137,7 +137,7 @@ jobs: error_count=$((error_count + 1)) echo "Warning: Generic favicon detected for domain: $domain (SHA-256: $file_hash)" else - # Valid favicon downloaded - use full domain as filename + # Valid favicon downloaded - use domain as filename favicon_file="favicons/${domain}.png" mv "$temp_favicon_file" "$favicon_file" diff --git a/README.md b/README.md index 43af7b119..a9d3a5d7c 100644 --- a/README.md +++ b/README.md @@ -14,10 +14,10 @@ This repository hosts a collection of favicon images for the world's most popula ### Access Individual Favicons -Individual favicons are stored in the `assets` branch and are named according to their second-level domain: +Individual favicons are stored in the `assets` branch and are named according to their domain name: -- `google.png` for google.com -- `github.png` for github.com +- `google.com.png` for google.com +- `github.com.png` for github.com Access patterns: @@ -114,15 +114,12 @@ You can modify the run.yml file to change: ### File Naming -Favicons are named based on the second-level domain: +Favicons are named using the domain name: -- `example.com` → `example.png` -- `subdomain.example.com` → `example.png` +- `example.com` → `example.com.png` +- `subdomain.example.com` → `subdomain.example.com.png` -When duplicate second-level domains exist, sequential numbers are added: - -- First `github.io` domain → `github.png` -- Second `github.io` domain → `github_1.png` +This ensures unique filenames for all domains and preserves the complete domain information. ### Error Handling